feat: API changes for handling new submission_email location
#3582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
RODO94
force-pushed
the
rory/submission-email-api-changes
branch
from
be27de5 to
f484485
Compare
|
Quick Pizza link for testing: https://3582.planx.pizza/buckinghamshire/submission-email-test |
DafyddLlyr
approved these changes
Aug 30, 2024
| // Confirm this local authority (aka team) has an email configured in teams.submission_email | ||
| const { sendToEmail, notifyPersonalisation } = | ||
| // Confirm this local authority (aka team) has an email configured in team_settings.submission_email | ||
| const { notifyPersonalisation } = |
There was a problem hiding this comment.
nit: If we're only using the sendToEmail field in this file, and not the rest of the notifyPersonalisation object, it would be cleaner / neater to destructure one level deeper here, and then not have to repeatedly write notifyPersonalisation.sendToEmail throughout the file 👍
Suggested change
| const { notifyPersonalisation } = | |
| const { notifyPersonalisation: { sendToEmail } } = |
There was a problem hiding this comment.
I think we are also using ...notifyPersonalisation for part of the code below. I'll keep as is now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR looks to alter references from
teams.submission_emailtoteam_settings.submission_email.I have ran through all references to
submission_email,sendEmail,submissionEmailand repointed them to the new reference.